Could "custom_timers" be renamed ?

[ZuluPro]

I don't use CustomTimer at all and only find Transaction.custom_timers to get custom data.

Maybe there's another way to do but I think it could be renamed simply values ?

[karec]

What's your need for custom data ? Could you give me an example ?

Custom timers are only used to get timing for specific tests (if you want to know how much time specific feature takes)

[ZuluPro]

I want to store result from commands, example for curl:

{"time_redirect":0.0,"time_pretransfer":0.013,"time_appconnect":0.0,"time_starttransfer":0.236,"time_namelookup":0.012,"time_connect":0.013,"time_total":0.239}

[karec]

I think we can rename it timers but values may be not explicit. CustomTimers are very specific and they are compiled by the core at the end of the tests.

[ZuluPro]

But timer is also inapropriate, I imagine sysbench data:

(venv) zulu@zuluvm:~/projects/cs-suite/cs_oct$ cat /tmp/sysbench_ram
sysbench 0.4.12:  multi-threaded system evaluation benchmark

Running the test with following options:
Number of threads: 4

Doing memory operations speed test
Memory block size: 1K

Memory transfer size: 102400M

Memory operations type: write
Memory scope type: global
Threads started!
Done.

Operations performed: 104857600 (2320057.25 ops/sec)

102400.00 MB transferred (2265.68 MB/sec)


Test execution summary:
    total time:                          45.1961s
    total number of events:              104857600
    total time taken by event execution: 117.7050
    per-request statistics:
         min:                                  0.00ms
         avg:                                  0.00ms
         max:                                 18.72ms
         approx.  95 percentile:               0.00ms

Threads fairness:
    events (avg/stddev):           26214400.0000/124550.07
    execution time (avg/stddev):   29.4263/0.18

[karec]

I think we can add this for the upcoming V1 :)

But why renaming timers ? I think we can simply add new variable for this type of informations

[ZuluPro]

I think renaming because when I measure charge, I don't think in term of "How much time it takes ?" but more "How much can I do in X seconds ?"
Timers may not be appropriate to all tests (in my opinion)

[karec]

It may not, but I still think that many tests will need it, because timers can answer to the question : during test, how specifics actions response time evolved. Custom timers allow users to add more granularity during tests, rather than only get timing for a full transaction.

But custom timers still in final report, so with results_ts_interval configuration you can actually answer the question "How much can I do in X seconds"