Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Overlay Rendering #73

Closed
cech12 opened this issue Sep 24, 2020 · 4 comments
Closed

[Feature] Overlay Rendering #73

cech12 opened this issue Sep 24, 2020 · 4 comments
Assignees
Labels
type: enhancement New feature or request

Comments

@cech12
Copy link

cech12 commented Sep 24, 2020

Please describe the new feature or change.
It would be nice if there will be a possibility to render an overlay when wearing an item in a curio slot. Like the overlay when wearing a carved pumpkin on head. In Forge there is already a possibility to add it for items wearing in vanilla armor slots but I cannot find a way to do it for curio slots.

Please describe why you want this feature.
My mod (Useful Hats) adds an aquanaut helmet to the game and when on head it renders an overlay (see here). Recently I added the support for Curios and I found out that there is no possibility for me to render it when in curios head slot.

@Aizistral
Copy link
Contributor

This is a hella specific feature if you'd ask me. But I can try to figure this one out and make a pull request to forge branch on the matter if @TheIllusiveC4 confirms that it totally makes sense in an API.

@cech12
Copy link
Author

cech12 commented Sep 26, 2020

That would be very nice! :)

@TheIllusiveC4
Copy link
Owner

Hmm, it is rather specific. It might be a little too niche. Also, can't you subscribe to the RenderGameOverlayEvent (or whatever it's called), listen for the helmet overlay, and render your logic in that? Basically, wherever Forge does their logic for their IForgeItem#renderHelmetOverlay method.

@cech12
Copy link
Author

cech12 commented Sep 28, 2020

Okay, I will try to use the RenderGameOverlayEvent. Thanks for the hint! :)

@cech12 cech12 closed this as completed Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants