Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android 5] Rotate icon in icon edit mode is cropped #636

Closed
Altonss opened this issue Nov 29, 2021 · 5 comments · Fixed by #778
Closed

[Android 5] Rotate icon in icon edit mode is cropped #636

Altonss opened this issue Nov 29, 2021 · 5 comments · Fixed by #778
Labels
android: 5 state: blocked by upstream Can't currently be done due to a limitation of Android or another upstream type: bug Something isn't working

Comments

@Altonss
Copy link
Contributor

Altonss commented Nov 29, 2021

image
System information:

Android 5.0.1
Device: Samsung Galaxy Core Prime
@TheLastProject TheLastProject changed the title Rotate icon in icon edit mode is cropped [Android 5] Rotate icon in icon edit mode is cropped Nov 29, 2021
@TheLastProject
Copy link
Member

I can confirm this issue on Android 5 (it works well on newer Android version).

Please report this issue to uCrop, as we just use that library as-is and haven't made any changes that could cause this.

@TheLastProject TheLastProject added state: blocked by upstream Can't currently be done due to a limitation of Android or another upstream type: bug Something isn't working labels Nov 29, 2021
@Altonss
Copy link
Contributor Author

Altonss commented Nov 29, 2021

Please report this issue to uCrop, as we just use that library as-is and haven't made any changes that could cause this.

Sadly I don't think that the used library is still actively developed. I would need to read more in-depth this thread Yalantis/uCrop#715 but the last commit is from August 2020.

This was referenced Nov 29, 2021
Open
Open
@Altonss
Copy link
Contributor Author

Altonss commented Jan 21, 2022

The issue will probably fixed soon, see the WIP here: Yalantis/uCrop#794 (comment) 🎆

@Altonss
Copy link
Contributor Author

Altonss commented Jan 26, 2022

The PR has been merged upstream Yalantis/uCrop#806
Now we just need to wait for the new version (2.2.8) to be released and test out if the fix works correctly :)

@Altonss
Copy link
Contributor Author

Altonss commented Jan 31, 2022

The new version 2.2.8 has been released 🎆

This was referenced Jan 31, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
android: 5 state: blocked by upstream Can't currently be done due to a limitation of Android or another upstream type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update to 2.2.8 version of ucrop! Altonss/Catima
2 participants
@TheLastProject @Altonss