Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary response manipulation #2

Closed
shadowhand opened this issue Nov 16, 2015 · 1 comment
Closed

Unnecessary response manipulation #2

shadowhand opened this issue Nov 16, 2015 · 1 comment
Assignees
@hajekj
Milestone
1.0.0

Comments

@shadowhand
Copy link

This double json encode/decode is not necessary and breaks the return type hinting of the AbstractProvider, which says that responses return array, not object.
hajekj added a commit that referenced this issue Nov 16, 2015
@hajekj
Fix for #2
619f3ee
hajekj added a commit that referenced this issue Nov 16, 2015
@hajekj
Additional #2 related fixes.
ed54fd6
hajekj added a commit that referenced this issue Nov 16, 2015
@hajekj
Additional #2 related fix.
c04b54d
@hajekj
Copy link
Member

hajekj commented Nov 16, 2015

This should now be fixed. Thank you for pointing this out.

@hajekj hajekj closed this as completed Nov 16, 2015
@hajekj hajekj added this to the 1.0.0 milestone Nov 16, 2015
@hajekj hajekj self-assigned this Nov 16, 2015
hajekj added a commit that referenced this issue Dec 11, 2015
@hajekj
Fix for treating $response as object instead of array
94a2060 
Realted to #2
hajekj added a commit that referenced this issue Jan 13, 2016
@hajekj
Fix for example code flow
e70d5d3 
Mistakenly treating the API response as an object, when it should be treated as an associative array instead. Related to #2.
@jcrumpOS jcrumpOS mentioned this issue Feb 13, 2018
Closed
@decomplexity decomplexity mentioned this issue Jul 11, 2020
Closed
@selimirez selimirez mentioned this issue Sep 25, 2020
Open
@RaminMohazzab RaminMohazzab mentioned this issue Feb 16, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hajekj hajekj

Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@shadowhand @hajekj