Maintenance, tests and fieldValue to allow more control over the filter
#3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added tests, needed to fix the setup a bit to make it work * Ran formatter
AdriVanHoudt
force-pushed
the
updates
branch
from
d750808
to
b9bf56d
Compare
|
I appreciate it very much. I’ll review it asap |
Char2sGu
approved these changes
Nov 18, 2023
|
@AdriVanHoudt Thanks for your great efforts. I have made some updates on this PR, but would need you to |
|
@TheNightmareX awesome! |
|
Then I won’t be able to squash commit it as a feature, but it’s fine, will do. |
|
@AdriVanHoudt Checkout the docs for the new feature. The option has been renamed to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know this is a lot for 1 pr and I will add some more tests still, but let me know if you'd want to merge this (in any form) otherwise we'd have to publish our own version (which is not an issue but I'd rather have 1 version of this)