Replacing Klaxon in favor of Moshi in lookup() function
#44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nickersoft
requested changes
Nov 6, 2022
Nickersoft
reviewed
Nov 6, 2022
| } | ||
|
|
||
| companion object { | ||
| private val moshi = Moshi.Builder().addLast(KotlinJsonAdapterFactory()).build() | ||
|
|
||
| private val innerLookupType = Types.newParameterizedType(MutableList::class.java, Entry::class.java) |
Nickersoft
reviewed
Nov 6, 2022
|
|
||
| private val innerLookupType = Types.newParameterizedType(MutableList::class.java, Entry::class.java) | ||
| private val outerLookupType = Types.newParameterizedType(MutableList::class.java, innerLookupType) | ||
| private val lookupAdapter: JsonAdapter<List<List<Entry>>> = moshi.adapter(outerLookupType) |
Nickersoft
approved these changes
Nov 6, 2022
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a fairly quick and dirty for the
lookup()function. It can now parse the nested list of objects coming fromODictusing Moshi. I'll probably see how to get it to work with Klaxon too.Update
Removing Klaxon completely in favor of Moshi since the former cannot handle nested lists in the form of
List<List<Entry>>.