Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I checked the latest changes with StatList, I have bad news #27

Closed
Araksson opened this issue May 8, 2021 · 2 comments
Closed

I checked the latest changes with StatList, I have bad news #27

Araksson opened this issue May 8, 2021 · 2 comments

Comments

@Araksson
Copy link

Araksson commented May 8, 2021

The errors remain exactly the same.

This was added that LoadItemStatCost does not read the OPs 0/8/9/10/11 that correspond to the same OPs that fail with the STATLIST_UpdateUnitNewStat function and STATLIST_InsertStatModOrFail

(As a side note, LoadISC from the pre-bulk changes version worked fine (it's the one I'm using))

Sorry for my slowness, I still haven't finished rearranging all my code, it's very long and I didn't check even half of the D2Moo functions (corresponding to ItemsFunctions, DRLG, Path and Missiles).
The good news is that I have made several fixes to the Path and Skills functions to make them work much better (and in some cases, to work directly).

And with Statlist I can't fix those errors.

I also don't have enough time to repair all the maximum details, but I would like to get it since it is very useful to handle all the statlists to try to expand them a bit with some custom code (in addition to expanding the ISC OPs which are also very useful)

@Lectem
Copy link
Member

Lectem commented May 9, 2021

It seems the issue is related to 0x6FDB64A0 (what you call STATLIST_UpdateUnitNewStat).

The other functions look fine to me
Using an amulet with both STATLIST_InsertStatModOrFail and LoadItemStatCost:
image
On a character with base stats:
image
Yields
image

However when using STATLIST_UpdateUnitNewStat it indeed give me something wrong (without even using the amulet!)
image

I'll investigate.

Lectem added a commit that referenced this issue Jun 1, 2021
@Lectem
Copy link
Member

Lectem commented Aug 1, 2021

I think #28 fixed this, feel free to reopen if issues remain.

@Lectem Lectem closed this as completed Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants