Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

News #29

Closed
Araksson opened this issue May 10, 2021 · 4 comments
Closed

News #29

Araksson opened this issue May 10, 2021 · 4 comments

Comments

@Araksson
Copy link

D2Common.0x6FDB64A0 and LoadItemStatCost Now they seem to work properly, however the STATLIST_InsertStatModOrFail_6FDB7690 and D2Common.0x6FDB5830 functions are not working properly.

STATLIST_InsertStatModOrFail_6FDB7690 it's wrong in some ISC, example: Cold Skill Damage %
D2Common.0x6FDB5830 it has a problem with the Auras. The auras of nearby friendly units do not share it with other friendly units (disabling it works perfectly).

@Lectem
Copy link
Member

Lectem commented May 14, 2021

Do you have more details about the Auras ?

It seems to work fine for me after patching 0x6FDB5830 by using an act2 mercenary.
image

@Araksson
Copy link
Author

I checked all the code (this time updated) and only found 2 functions not working.

STATLIST_InsertStatModOrFail (sub_6FDB7690) Wrong ISC With OP 2
STATLIST_SetStat (#10463) Not Load The Game

in the case of the last function, in Vanilla it seems to be a independent function (which doesn't just make a call and "go"), and uses pUnit.

Lectem added a commit that referenced this issue Jun 1, 2021
@Lectem
Copy link
Member

Lectem commented Nov 11, 2022

It's been a while and afaik I couldn't reproduce the issue (however it does not mean it is fixed).
Should I keep this issue open ?

@Araksson
Copy link
Author

It's been a while and afaik I couldn't reproduce the issue (however it does not mean it is fixed). Should I keep this issue open ?

Those issues were fixed.

@Lectem Lectem closed this as completed Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants