Added Palindrome in Kotlin

[anohene1]

Congrats on taking the first step to contributing to the Sample Programs repository maintained by The Renegade Coder!
For simplicity, please make sure that your pull request includes one and only one contribution.

Complete the Applicable Sections Below

Find which section best describes your pull request and make sure you fill it out. To start, let us know which issue you've fixed.

• I fixed #your-issue-number-here

Code Snippets

• I named the pull request using Added/Updated <Sample Program> in <Language> format
• I created/updated the language README
  • I added the sample program name to the README
  • I added fun facts (i.e. debut developer, typing, etc.)
  • I added reference link(s) to the README
  • I added solution citations when necessary (see plagiarism)

Testing

• I named the pull request using Added/Updated <Language>/<Project> Testing format
• I followed the testinfo template, if applicable

Notes

Feel free to describe what you added or updated.

[jrg94]

We don't currently support palindrome, but we're open to including this if we can get it documented. Let me know if that's something you want to do!

[anohene1]

Sure. I'll do that. Let me know where to document it.

[jrg94]

Check out this repo: https://github.com/TheRenegadeCoder/sample-programs-website

You'll want to create something that looks like one of these: https://sample-programs.therenegadecoder.com/projects/

[anohene1]

I have done that and made a pull request. You can check it at TheRenegadeCoder/sample-programs-website#349

[jrg94]

Cool! Now we have the specification, let's get some tests going. There's a bit of a dependency in our way at the moment. See #2186. That said, we can add the test file here: https://github.com/TheRenegadeCoder/sample-programs/tree/master/test

[anohene1]

I'm sorry I don't get you quite well. Should the test be in python? As I can see all the test files are written in python.

[jrg94]

Yes! But the test files are more or less copy-and-paste. You should be able to copy binary-search.py and reuse most of it.

[anohene1]

Okay I'll go ahead and try that. I'll let you know if I'm done.

[anohene1]

This is getting very difficult for me as I have no knowledge in python.

[jrg94]

No worries! I can give you a rough idea of what you need to do. First, I'd copy the contents of the binary search test.

[jrg94]

Then, replace BinarySearch with PalindromicNumbers.

[jrg94]

Then, at the top of the file, you should see these:

invalid_permutations = (
    'description,in_params,expected', [
        (
            'no input',
            None,
            'Usage: please provide a list of sorted integers ("1, 4, 5, 11, 12") and the integer to find ("11")'
        ), (
            'missing input: target',
            '"1, 2, 3, 4"',
            'Usage: please provide a list of sorted integers ("1, 4, 5, 11, 12") and the integer to find ("11")'
        ), (
            'missing input: list',
            '"" "5"',
            'Usage: please provide a list of sorted integers ("1, 4, 5, 11, 12") and the integer to find ("11")'
        ), (
            'out of order input',
            '"3, 5, 1, 2" "3"',
            'Usage: please provide a list of sorted integers ("1, 4, 5, 11, 12") and the integer to find ("11")'
        )
    ]
)

valid_permutations = (
    'description,in_params,expected', [
        (
            'sample input first true',
            '"1, 3, 5, 7" "1"',
            'true'
        ), (
            'sample input last true',
            '"1, 3, 5, 7" "7"',
            'true'
        ), (
            'sample input middle true',
            '"1, 3, 5, 7" "5"',
            'true'
        ), (
            'sample input one true',
            '"5" "5"',
            'true'
        ), (
            'sample input one false',
            '"5" "7"',
            'false'
        ), (
            'sample input many false',
            '"1, 3, 5, 6" "7"',
            'false'
        )
    ]
)

[jrg94]

These are the tests. You need to replace these tests with the one's you wrote. For example, the first invalid test looks like this:

(
            'no input',
            None,
            'Usage: please provide a list of sorted integers ("1, 4, 5, 11, 12") and the integer to find ("11")'
)

You can replace it with this:

(
            'no input',
            None,
            'Usage: please input a number'
)

[anohene1]

I have finished editing the test file. You may check and let me know what else I need to do please.

[jrg94]

Looks good so far!

[jrg94]

After this, you'll need to update both of these:

• https://github.com/TheRenegadeCoder/sample-programs/blob/master/runner.py
• https://github.com/TheRenegadeCoder/sample-programs/blob/master/.glotter.yml

[anohene1]

I have made both updates

[jrg94]

Looks good! The only issue is the program you wrote will fail your own tests. We don't have a way to prove that just yet because someone is currently adding Kotlin testing.

[anohene1]

Okay. So what do I do now?

[jrg94]

Update the Kotlin script to match your tests. Then, we're stuck waiting on #2186. Though, I'm not against merging this and letting that pull request solve the issue.

[anohene1]

I have fixed that.

[jrg94]

I'm not sure your program matches your tests, but we'll go ahead and merge it for now. When Kotlin testing is implemented, we'll clean things up.