Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Baklava in Phix #2382

Merged
merged 5 commits into from
May 7, 2021
Merged

Add Baklava in Phix #2382

merged 5 commits into from
May 7, 2021

Conversation

petelomax
Copy link
Contributor

@petelomax petelomax commented Feb 16, 2021

I Am Adding a New Code Snippet in a New Language

  • I named the pull request using Add {PROJECT} in {LANGUAGE} format
  • I created/updated the language README (see [contributing documentation][contributing-readme])
    • I added the sample program name to the README
    • I added fun facts (i.e. debut developer, typing, etc.)
    • I added reference link(s) to the README
    • I added solution citations when necessary (see [plagiarism][contributing-plagiarism])

Other Notes

Sorry, the testinfo.yml is untested, best I can do

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @petelomax! Thanks for contributing to this project! We are a rather small team, so it may take some time to process this request. In the meantime, there are several ways you can make yourself a part of The Renegade Coder community. For instance, you can:

Thanks for your help!

@jrg94 jrg94 self-assigned this Feb 22, 2021
@jrg94 jrg94 added baklava See: https://sampleprograms.io/projects/baklava/ enhancement Any code that improves the repo labels Feb 22, 2021
@jrg94 jrg94 added this to the 200 Languages milestone Feb 22, 2021
Copy link
Member

@jrg94 jrg94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far! I'm having trouble finding the Docker image for this language. Looks like our CI is as well. Any idea if one exists?

@petelomax
Copy link
Contributor Author

I'd put serious money on there not being one, and even more on there not being an up-to-date one.

@jrg94
Copy link
Member

jrg94 commented Feb 22, 2021

Makes sense! I think you can go ahead and remove the test_info file for now then. Ideally, we'd want to automate testing on this, but I don't want to turn away new languages that don't necessarily have docker support.

@jrg94 jrg94 marked this pull request as ready for review May 7, 2021 21:18
@jrg94 jrg94 merged commit f8bee90 into TheRenegadeCoder:master May 7, 2021
@petelomax petelomax deleted the patch-1 branch May 8, 2021 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
baklava See: https://sampleprograms.io/projects/baklava/ enhancement Any code that improves the repo
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants