This repository has been archived by the owner on Dec 14, 2021. It is now read-only.
Types package randomizers #628
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
htdvisser
suggested changes
Jun 20, 2017
core/types/random.go
Outdated
| func NewPopulatedDevAddr(r Rand) (devAddr *DevAddr) { | ||
| devAddr = &DevAddr{} | ||
| if _, err := randRead(r, devAddr[:]); err != nil { | ||
| panic(fmt.Errorf("types.NewPopulatedAppEUI: %s", err)) |
There was a problem hiding this comment.
Panic should say NewPopulatedDevAddr
htdvisser
approved these changes
Jun 20, 2017
|
Squash-merged in 3715af8 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lack of these randomizers prevent using gogoproto
populateoption to auto-generate randomizers for types in NOC. This implementation does not add any additional dependencies to thecore/typespackage, (test code is in separatetypes_testpackage) as was determined to be a requirement in previous discussion with @htdvisser.Readfunction is not used, as interface generated bygogoprotodoes not provide it andInt63()is used under the hood anyway. Pointers are returned to matchgogoprotoexpectations.