This repository has been archived by the owner on Dec 14, 2021. It is now read-only.
Mask sensitive information in error messages #683
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
johanstokking
commented
Nov 8, 2017
johanstokking
commented
- Masking an app ID if the claims do not contain access to the app ID
- Masking an underlying error from the Account Server
htdvisser
suggested changes
Nov 10, 2017
| @@ -55,7 +58,8 @@ func (h *handlerManager) validateTTNAuthAppContext(ctx context.Context, appID st | |||
| } | |||
| token, err := h.handler.Component.ExchangeAppKeyForToken(appID, key) | |||
| if err != nil { | |||
| return ctx, nil, err | |||
| h.handler.Ctx.WithError(err).Warn("Could not exchange key for token") | |||
| return ctx, nil, errors.NewErrPermissionDenied("Could not exchange key for token") | |||
There was a problem hiding this comment.
I think we should do this in the ExchangeAppKeyForToken func, as this error may either be caused by misconfiguration of the handler, or by an invalid access key. The first should be an InternalServerError, the second indeed a PermissionDenied
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.