chore($fw.Modal): remove focus hack which used to prevent jumping #3221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please test cc. @ViorelEremia @danyj |
|
I would wait till 4.9.5, all theme devs on TF need to support 2 versions back so removing this now can result in new tickets from users who are on 4.9.1,4.9.2 |
|
No one's going to notice it, it's a very simple jump & a lot of users didn't even noticed it and I bet |
|
@andreiglingeanu seems that your bet was wrong :) |
|
Hmm, that definitely should not happen... We can temporarily restore the previously made hack anyway |
|
lol @andreiglingeanu I had to do this
|
|
😁thanks! Same to you! |
|
@andreiglingeanu looks like we will need this again , with latest Unyson 2.7.20 jumping is back big time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally fix #2399. https://core.trac.wordpress.org/ticket/39859 got merged in
4.9.3in core, everything works now without any hacks from our side!More context for the issue: #2388