-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--ignore_crc not working properly in partclone 3.12 #121
Comments
Wow so glad I found this issue. I'm experiencing the very same thing. Did you find a solution / workaround? |
I assume my issue here could be related: #109 |
this problem only occurs when you use the --ignore_crc command option when restoring an image. the new partclone format changed the checksum mechanism but i suspect that the functions for ignoring checksums were either forgot or were updated with errors. restoring an image without using the --ignore_crc command option works fine. |
If opt.ignore_crc is set, must not check the (uncomputed) checksum of the latest chunk
@Thomas-Tsai Working together with @junkhacker on FOG project we make heavy use of partclone and I just stumbled upon this issue again. The fix proposed by @cdeleuze might be a first step but in my tests an image captured with partclone 0.2.89 is still being corrupted when deploying it with partclone 0.3.x (currently we use 0.3.13 + 72054f1) but without any error message whatsoever. Looking through the code and comparing images written with and without the |
Reset variable blocks_in_cs to make sure we skip checksum bytes instead of writing those out to disk
@Thomas-Tsai @partclone Would you please take a look at the proposal to fix the issue initially reported by @junkhacker? The FOGproject heavily depends on using partclone and we'd like to contribute as good as we can. |
sorry for the reply late. I just manual update main.c and just accept the patch from proposal to fix the issue. I will give a test and release ASAP. |
… with image files created with partclone 0.2.89. For more information see Thomas-Tsai/partclone#121
restoring an image created with partclone 2.89 with partclone.restore 3.12 and --ignore_crc flag enabled results in a corrupt restore to device but does not report an error
restoring an image created with partclone 3.12 with partclone.restore 3.12 and --ignore_crc flag enabled results in a crc error while finishing the write to device (before it usually says SYNCING...OK)
an image created with partclone 3.12 using -aX0 flag restored with partclone.restore 3.12 and --ignore_crc flag enabled works fine
The text was updated successfully, but these errors were encountered: