Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Measured time is dependant on TimerObservers' actions #16

Open
Thomsch opened this issue Sep 10, 2017 · 0 comments
Open

Measured time is dependant on TimerObservers' actions #16

Thomsch opened this issue Sep 10, 2017 · 0 comments
Milestone

Comments

@Thomsch
Copy link
Owner

Thomsch commented Sep 10, 2017

The current implementation of the timer calls directly its observers. For our usecase, the overhead of the calls on the work duration is negligeable. But, if an observer wanted to do a blocking call, it would also block the timer which is not wanted.
A consumer thread should be added to handle the calls to the observers. The timer would then only post updates in a safe way to the consumer thread. Preventing it to be blocked.

@Thomsch Thomsch added this to the 0.8 milestone Sep 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant