Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ListPeer creates a new background context #7

Closed
ecbaldwin opened this issue May 14, 2021 · 0 comments · Fixed by #8
Closed

ListPeer creates a new background context #7

ecbaldwin opened this issue May 14, 2021 · 0 comments · Fixed by #8

Comments

@ecbaldwin
Copy link
Contributor

I noticed that ListPeer creates its own background context rather than using the stream context as in MonitorPeer. It probably shouldn't do that and follow MonitorPeer's example.
ecbaldwin added a commit to ecbaldwin/bfd that referenced this issue May 14, 2021
@ecbaldwin
make ListPeer use the stream context
0f61414 
Rather than creating its own context, use the one available from the
stream. This follows the example from MonitorPeer.

fixes: thoro#7
@ecbaldwin ecbaldwin mentioned this issue May 14, 2021
Merged
@thoro thoro closed this as completed in #8 May 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make ListPeer use the stream context ecbaldwin/bfd
1 participant
@ecbaldwin