switch to a maintained uuid library #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, I see that a new commit to convert to go.mod has been merged. Nice. I was about to do that following this. I will rebase this PR to that. |
It seems [this uuid library was forked a few years ago due to lack of maintenance][1]. There was also an API change between v1.2.0 and master which can cause issues depending on which version gets downloaded as I discovered recently. [1]: satori/go.uuid#103
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems this uuid library was forked a few years ago due to lack of
maintenance. There was also an API change between v1.2.0 and
master which can cause issues depending on which version gets downloaded
as I discovered recently.