Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard dependency on org-id guide site #91

Open
michaelwood opened this issue Jun 5, 2023 · 0 comments
Open

Hard dependency on org-id guide site #91

michaelwood opened this issue Jun 5, 2023 · 0 comments

Comments

@michaelwood
Copy link
Member

The dataquality tool has a hard dependency on http://org-id.guide/download.json, if this is unavailable the tool doesn't degrade gracefully.

    from lib360dataquality.cove.threesixtygiving import (
  File "/home/datastore/datastore/.ve/src/lib360dataquality/lib360dataquality/cove/threesixtygiving.py", line 37, in <module>
    orgids_prefixes = get_orgids_prefixes()
  File "/home/datastore/datastore/.ve/lib/python3.8/site-packages/libcove/lib/common.py", line 1409, in get_orgids_prefixes
    org_id_file_contents = requests.get(orgids_url).json()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant