-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add region and country to geo lookups #71
Comments
Fixing this partly depends on these codes being available in https://github.com/drkane/geo-lookups/ (or similar format) - I've now updated this so there are files for region, country and combined authority. So it should just be a case of adding the files to datastore/datastore/additional_data/sources/geo_lookup.py Lines 14 to 50 in 94cf545
|
I've now added equivalent files for regions and countries to the geo-lookups repository, so it should be straightforward to add these to the We should also include the Upper tier local authorities and Combined Authority files here too. |
@drkane do you have preferences on what field names should be called? or should we just use |
Those work for me! |
…ries, upper tier local authorities and combined authority. #71
Adds data sources for regions, countries, upper tier local authorities and combined authority. Fixes #71 Co-authored-by: Michael Wood <michael.wood@opendataservices.coop>
Adds data sources for regions, countries, upper tier local authorities and combined authority. Fixes #71 Co-authored-by: Michael Wood <michael.wood@opendataservices.coop>
At the moment a geocode in recipient or beneficiary location is ignored if it's a country or a region. These should be added as
GeoLookup
objects so that they can be included in the data.The example given was WCVA who publish grants with a geocode of
W92000004
- eg https://grantnav.threesixtygiving.org/grant/360G-WCVA-27082The data would need to be added to https://github.com/ThreeSixtyGiving/datastore/blob/master/datastore/additional_data/sources/geo_lookup.py
The text was updated successfully, but these errors were encountered: