Skip to content
This repository has been archived by the owner on Dec 10, 2018. It is now read-only.

Different types with the same name should cause Duplicate typename error #76

Closed
hit9 opened this issue Jan 13, 2015 · 6 comments
Closed
Labels

Comments

@hit9
Copy link
Contributor

hit9 commented Jan 13, 2015

E.g. the following thrift should cause duplicate typename error

struct foo {}
enum foo {}

But this wasn't handled in thriftpy.

@hit9 hit9 added the Bug label Jan 13, 2015
@hit9
Copy link
Contributor Author

hit9 commented Jan 13, 2015

excludes namespace, includes, const, all other types: enum, struct, union, exception, service, should use the same namespace, that means they cannot use the same name with different types.

@hit9
Copy link
Contributor Author

hit9 commented Jan 13, 2015

New thrift parser model thrift should contains:

includes
constants
namespaces
ttypes

@hit9
Copy link
Contributor Author

hit9 commented Jan 17, 2015

Also the field names should be independent in a srruct/function.

@hit9
Copy link
Contributor Author

hit9 commented Jan 17, 2015

And deprecate union support (What data structure in py should I use for union..

@hit9
Copy link
Contributor Author

hit9 commented Jan 23, 2015

Will be fixed in #80

@hit9
Copy link
Contributor Author

hit9 commented Jan 24, 2015

Closed via #80 .

@hit9 hit9 closed this as completed Jan 24, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant