Skip to content
This repository has been archived by the owner on Dec 10, 2018. It is now read-only.

Reset self.sock if connection fails #298

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Reset self.sock if connection fails #298

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4a3385b
Reset self.sock if connection fails
ecederstrand Jun 19, 2017
c85cb5d
Always set self.sock=None on close()
ecederstrand Jun 20, 2017
ec73667
Add tests for is_open() on failure
Jul 31, 2017
8e047cc
Remove timeout args as suggested by @wbolster
Aug 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion thriftpy/transport/socket.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ def open(self):
self.sock.settimeout(self.socket_timeout)

except (socket.error, OSError):
self.sock = None
raise TTransportException(
type=TTransportException.NOT_OPEN,
message="Could not connect to %s" % str(addr))
Expand Down Expand Up @@ -140,7 +141,7 @@ def close(self):
self.sock.close()
self.sock = None
except (socket.error, OSError):
pass
self.sock = None


class TServerSocket(object):
Expand Down