Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appears to have a dependency on PostSharp a paid for third party sdk #5

Open
dizzy2003 opened this issue Mar 11, 2023 · 3 comments
Open

Comments

@dizzy2003
Copy link

No description provided.

@NameOfTheDragon
Copy link
Member

NameOfTheDragon commented May 20, 2023

@dizzy2003 I just noticed that myself today. I don't think that's intended but I'll review my use of PostSharp to see if it can be removed. PostSharp is actually free in certain circumstances so it isn't necessarily a showstopper, but I agree it is too heavyweight a dependency for this type of library.

@NameOfTheDragon
Copy link
Member

It turns out this work had already been done, along with other improvements such as a FITS Writer, and was sitting unreleased in the develop branch. I have tidied this up and started a beta release for version 1.1.0. @dizzy2003 perhaps you would like to have a look at the pull request #7 and see if that is more to your liking. The Postsharp dependency has gone, as has the NLog, JetBrains and some others.

@Priv-Stefan
Copy link

Hello

The PostSharp is removed from the github repository, but it is still in the Nuget package.

S.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants