Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix two instance of improper memory free for deserialization. #70

Merged
merged 1 commit into from
May 1, 2019
Merged

Fix two instance of improper memory free for deserialization. #70

merged 1 commit into from
May 1, 2019

Conversation

tdenniston
Copy link
Contributor

The callers of these functions are responsible for freeing the given byte buffer. This allows for zero-copy during deserialization.

@tdenniston
Fix two instance of improper memory free for deserialization.
7ca23c7 
The callers of these functions are responsible for freeing the
given byte buffer. This allows for zero-copy during deserialization.
@tdenniston tdenniston requested a review from Shelnutt2 May 1, 2019 19:03
Shelnutt2
Shelnutt2 approved these changes May 1, 2019
View reviewed changes
Copy link
Member

@Shelnutt2 Shelnutt2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tdenniston tdenniston merged commit c4c4cb6 into ss/rest-support May 1, 2019
@tdenniston tdenniston deleted the ttd/deserialize-free-fix branch May 1, 2019 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shelnutt2 Shelnutt2 Shelnutt2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tdenniston @Shelnutt2