Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalize query condition parsing to non-INT32 index columns #614

Merged
merged 3 commits into from
Nov 6, 2023
Merged

Generalize query condition parsing to non-INT32 index columns #614

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
864b020
Generalize query condition parsing to non-INT32 index columns
eddelbuettel Nov 6, 2023
0e53d20
Add test for non-int32 columns and parsing query conditions
eddelbuettel Nov 6, 2023
3667897
Update NEWS [ci skip]
eddelbuettel Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion R/QueryCondition.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ parse_query_condition <- function(expr, ta=NULL, debug=FALSE, strict=TRUE, use_i
" [",ch, "] ", dtype, "\n", sep="")

## take care of factor (aka "enum" case) and set the data type to ASCII
if (dtype == "INT32" && is_enum) {
if (dtype %in% c("INT8", "INT16", "INT32", "INT64", "UINT8", "UINT16", "UINT32", "UINT64") && is_enum) {
if (debug) cat(" [factor column] ", ch, " ", attr, " ", dtype, " --> ASCII", " ", is_enum, "\n")
dtype <- "ASCII"
}
Expand Down