Generalize query condition parsing to non-INT32 index columns #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddelbuettel
requested review from
ihnorton,
aaronwolen,
johnkerl,
awenocur and
mojaveazure
|
This pull request has been linked to Shortcut Story #36509: [r] Fix query conditions on enumerated columns. |
awenocur
approved these changes
Nov 6, 2023
johnkerl
requested changes
Nov 6, 2023
|
@johnkerl Please supply the unit test. The package has no 'from-arrow' writer. |
|
Thinko on my part. Can likely do it 'the long way' wrapping the core API. Will attempt later. |
24 tasks
This was referenced Nov 6, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR generalized support for parsing of query condition from user supplied text to arrays not created from R
factorsand using indices with types different fromint32_t.