Do not load group metadata when getting it from REST. #4821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #43504: Segfault in Cloud smoke test with 2.21 / Py 0.27. |
ihnorton
requested changes
Mar 21, 2024
This was introduced in #4760 where the client tries to load the group metadata when serializing the group metadata request to REST, which causes an infinite loop. The fix reverts to the correct behavior, where we don't try to load the metadata when serializing it from the client. --- TYPE: BUG DESC: Do not load group metadata when getting it from REST.
KiterLuc
force-pushed
the
lr/not-load-group-md-serialization/ch43504
branch
from
d25698c
to
8fc5f5a
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Mar 21, 2024
This was introduced in #4760 where the client tries to load the group metadata when serializing the group metadata request to REST, which causes an infinite loop. The fix reverts to the correct behavior, where we don't try to load the metadata when serializing it from the client. --- TYPE: BUG DESC: Do not load group metadata when getting it from REST. (cherry picked from commit 07b26fb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was introduced in #4760 where the client tries to load the group metadata when serializing the group metadata request to REST, which causes an infinite loop. The fix reverts to the correct behavior, where we don't try to load the metadata when serializing it from the client.
TYPE: BUG
DESC: Do not load group metadata when getting it from REST.