Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not load group metadata when getting it from REST. #4821

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Do not load group metadata when getting it from REST. #4821

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions tiledb/sm/serialization/group.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ Status group_metadata_to_capnp(
auto config_builder = group_metadata_builder->initConfig();
RETURN_NOT_OK(config_to_capnp(group->config(), &config_builder));

auto metadata = group->metadata();
Metadata* metadata = load ? group->metadata() : group->unsafe_metadata();
if (metadata->num()) {
auto metadata_builder = group_metadata_builder->initMetadata();
RETURN_NOT_OK(metadata_to_capnp(metadata, &metadata_builder));
Expand Down Expand Up @@ -157,7 +157,9 @@ Status group_details_to_capnp(
}
}

auto metadata = group->metadata();
Metadata* metadata = group->group_uri().is_tiledb() ?
group->unsafe_metadata() :
group->metadata();
if (metadata->num()) {
auto group_metadata_builder = group_details_builder->initMetadata();
RETURN_NOT_OK(metadata_to_capnp(metadata, &group_metadata_builder));
Expand Down
Loading