Theme detection failing

[mitchcapper]

Microsoft Visual Studio Enterprise 2022 (64-bit) - Preview
Version 17.10.0 Preview 2.0

use light theme by default after extension install though clearly defaulting to dark theme:

I see I can manually adjust each color but no manual theme selection.

[MagicAndre1981]

I have the same issue with the blue theme

[Tim-Maes]

I am aware of these issues, but haven't found the time to work on this project yet.

I'll try to implement an elegant way to handle themes, but that will probably be somewhere in september. In the meantime, feel free to open a PR - the logic for this is pretty simple (and was a quickfix implementation) here in the package file.

[MagicAndre1981]

the main issues is you hardcoded color values in strings

internal const string DarkTheme = "Color [A=255, R=31, G=31, B=31]";
internal const string LightTheme = "Color [A=255, R=245, G=245, B=245]";

If there is a minimal diff the compare fails (my detected values are Color [A=255, R=247, G=249, B=254] and this is why compare failed).

Small workaround is to basically change the compare in VSColorTheme_ThemeChanged to check for Dark instead of Light theme:

if (themedColor == Constants.DarkTheme)
    SetDarkThemeColors();
else
    SetLightThemeColors();

When I switch between buildin themes, it works now, but the light colors are still not that great to read.