Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On iPad, point the popovers directly at their container view. #50

Closed

Conversation

schustafa
Copy link

This adjusts the CGRect from which the picker should be presented to the containerView (rather than the whole window). Popovers should now point directly at the element from which they were invoked.

This may fix the issue described in #30, but I can't be sure of that.

[This pull request, with a topic branch, supersedes #49]

@skywinder
Copy link
Collaborator

Hi! Is it still actual problem? Can you provide screenshots to show what wrong with view size and position?

@ma2kubo
Copy link

ma2kubo commented May 26, 2014

Evernote was unable to submit your note for the following reason:

The emailed note was received, but Evernote did not understand the email address. It may have been mistyped, or the user may not exist. Please check to make sure the address was properly entered.

Original message information:
From: Petr Korolev <notifications@github.com>
Delivered To: deviceone.c1297@m.evernote.com
All recipients: TimCinel/ActionSheetPicker <ActionSheetPicker@noreply.github.com>
Subject: Re: [ActionSheetPicker] On iPad, point the popovers directly at their container view. (#50)

To prevent excessive emails, you may not receive another error reply for the next 360 minutes.

  • The Evernote team

@skywinder
Copy link
Collaborator

Is it the same as #97 ?

@ma2kubo
Copy link

ma2kubo commented May 27, 2014

Evernote was unable to submit your note for the following reason:

The emailed note was received, but Evernote did not understand the email address. It may have been mistyped, or the user may not exist. Please check to make sure the address was properly entered.

Original message information:
From: Petr Korolev <notifications@github.com>
Delivered To: deviceone.c1297@m.evernote.com
All recipients: TimCinel/ActionSheetPicker <ActionSheetPicker@noreply.github.com>; ma2kubo <ma2kubo@gmail.com>
Subject: Re: [ActionSheetPicker] On iPad, point the popovers directly at their container view. (#50)

To prevent excessive emails, you may not receive another error reply for the next 360 minutes.

  • The Evernote team

@skywinder
Copy link
Collaborator

Fixed. Let me know, if you still occur some issues and describe, how to reproduce it.

@skywinder skywinder closed this Jul 22, 2014
@ma2kubo
Copy link

ma2kubo commented Jul 22, 2014

Evernote was unable to submit your note for the following reason:

The emailed note was received, but Evernote did not understand the email address. It may have been mistyped, or the user may not exist. Please check to make sure the address was properly entered.

Original message information:
From: Petr Korolev <notifications@github.com>
Delivered To: deviceone.c1297@m.evernote.com
All recipients: TimCinel/ActionSheetPicker <ActionSheetPicker@noreply.github.com>; ma2kubo <ma2kubo@gmail.com>
Subject: Re: [ActionSheetPicker] On iPad, point the popovers directly at their container view. (#50)

To prevent excessive emails, you may not receive another error reply for the next 360 minutes.

  • The Evernote team

ChronicStim pushed a commit to ChronicStim/ActionSheetPicker that referenced this pull request Oct 16, 2014
Fix for UIDatePickerModeCountDownTimer callback
ChronicStim pushed a commit to ChronicStim/ActionSheetPicker that referenced this pull request Oct 16, 2014
- Remove unused init function.
- Add CountDownTimer support to blocks.
- Remove redudant countDownDuration init
ChronicStim pushed a commit to ChronicStim/ActionSheetPicker that referenced this pull request Oct 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants