Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct positioning after rotation in iPad #53

Closed
wants to merge 1 commit into from

Conversation

odanu
Copy link

@odanu odanu commented Aug 24, 2012

Implemented correct positioning after autorotation on iPad.
Possible additionally fixes issues #50, #42, #30

@skywinder
Copy link
Collaborator

Hi! Thanks for improvements.
Is it the same problem as #97 and #95?

@ma2kubo
Copy link

ma2kubo commented May 26, 2014

Evernote was unable to submit your note for the following reason:

The emailed note was received, but Evernote did not understand the email address. It may have been mistyped, or the user may not exist. Please check to make sure the address was properly entered.

Original message information:
From: Petr Korolev <notifications@github.com>
Delivered To: deviceone.c1297@m.evernote.com
All recipients: TimCinel/ActionSheetPicker <ActionSheetPicker@noreply.github.com>
Subject: Re: [ActionSheetPicker] Correct positioning after rotation in iPad (#53)

To prevent excessive emails, you may not receive another error reply for the next 360 minutes.

  • The Evernote team

@skywinder
Copy link
Collaborator

Hi. I tried to merge your pull request, but got some of UI issues. (see screenshots)
Probable this fix is outdated (since there is a lot of different fixes already implemented).
I didn't see anything suspicious in ActionSheetPicker behaviour.
But I see, that a lot of people have issues with iPad rotation.
Anyway, I'll create a pull request with merged to your repo. And If you can fix this issues - I'm ready to merge it.

screen shot 2014-07-22 at 09 44 54
screen shot 2014-07-22 at 09 45 03

@skywinder skywinder closed this Jul 22, 2014
@ma2kubo
Copy link

ma2kubo commented Jul 22, 2014

Evernote was unable to submit your note for the following reason:

The emailed note was received, but Evernote did not understand the email address. It may have been mistyped, or the user may not exist. Please check to make sure the address was properly entered.

Original message information:
From: Petr Korolev <notifications@github.com>
Delivered To: deviceone.c1297@m.evernote.com
All recipients: TimCinel/ActionSheetPicker <ActionSheetPicker@noreply.github.com>; ma2kubo <ma2kubo@gmail.com>
Subject: Re: [ActionSheetPicker] Correct positioning after rotation in iPad (#53)

To prevent excessive emails, you may not receive another error reply for the next 360 minutes.

  • The Evernote team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants