Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed position bug #97

Merged
merged 1 commit into from
May 27, 2014
Merged

fixed position bug #97

merged 1 commit into from
May 27, 2014

Conversation

elwerene
Copy link
Contributor

Some time ago I fixed a positioning bug on ipads. We use this in production and it works quite well, thanks.

@ma2kubo
Copy link

ma2kubo commented Feb 17, 2014

Evernote was unable to submit your note for the following reason:

The emailed note was received, but Evernote did not understand the email address. It may have been mistyped, or the user may not exist. Please check to make sure the address was properly entered.

Original message information:
From: =?UTF-8?B?UmVuw6kgUsO2c3NsZXI=?= <notifications@github.com>
Delivered To: deviceone.c1297@m.evernote.com
All recipients: TimCinel/ActionSheetPicker <ActionSheetPicker@noreply.github.com>
Subject: [ActionSheetPicker] fixed position bug (#97)

To prevent excessive emails, you may not receive another error reply for the next 360 minutes.

  • The Evernote team

@skywinder
Copy link
Collaborator

Hello. Can you show, how this bug has occurred? How I can reproduce it?

@ma2kubo
Copy link

ma2kubo commented May 26, 2014

Evernote was unable to submit your note for the following reason:

The emailed note was received, but Evernote did not understand the email address. It may have been mistyped, or the user may not exist. Please check to make sure the address was properly entered.

Original message information:
From: Petr Korolev <notifications@github.com>
Delivered To: deviceone.c1297@m.evernote.com
All recipients: TimCinel/ActionSheetPicker <ActionSheetPicker@noreply.github.com>; ma2kubo <ma2kubo@gmail.com>
Subject: Re: [ActionSheetPicker] fixed position bug (#97)

To prevent excessive emails, you may not receive another error reply for the next 360 minutes.

  • The Evernote team

@skywinder
Copy link
Collaborator

Also, timeZone support is very nice feature, but it's not related to this request, and it also implemented in #96
Please fix this commit, if you are still involved in this project contribution.

@skywinder
Copy link
Collaborator

Is this the bug, that described in #95 ?

@elwerene
Copy link
Contributor Author

Yes, it is. I remember the rect to be empty or sth. similar. It was a long time ago :)

@ma2kubo
Copy link

ma2kubo commented May 27, 2014

Evernote was unable to submit your note for the following reason:

The emailed note was received, but Evernote did not understand the email address. It may have been mistyped, or the user may not exist. Please check to make sure the address was properly entered.

Original message information:
From: =?UTF-8?B?UmVuw6kgUsO2c3NsZXI=?= <notifications@github.com>
Delivered To: deviceone.c1297@m.evernote.com
All recipients: TimCinel/ActionSheetPicker <ActionSheetPicker@noreply.github.com>; ma2kubo <ma2kubo@gmail.com>
Subject: Re: [ActionSheetPicker] fixed position bug (#97)

To prevent excessive emails, you may not receive another error reply for the next 360 minutes.

  • The Evernote team

@skywinder
Copy link
Collaborator

Yes. This Project not update for a long time.
But now I will try to make it alive.

- (void)presentActionSheet:(UIActionSheet *)actionSheet method have the same logic. Is it nedded to update this method too?

Can you remove timezone support from this commit?
Then I can merge it.

@elwerene
Copy link
Contributor Author

Removed the timezone support from the pull request. I don't know about the other method, but I guess you should update it too!

skywinder added a commit that referenced this pull request May 27, 2014
@skywinder skywinder merged commit 8bfe34b into TimCinel:master May 27, 2014
@skywinder
Copy link
Collaborator

Thank you! Many people will benefit from your effort! 👍

@elwerene elwerene deleted the positionFix branch May 27, 2014 13:44
skywinder added a commit that referenced this pull request Jun 23, 2014
This reverts commit 8bfe34b, reversing
changes made to 2c4e5ea.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants