-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Blur Window #46
Conversation
✔️ Deploy Preview for timerx-app canceled. 🔨 Explore the source changes: 35aa821 🔍 Inspect the deploy log: https://app.netlify.com/sites/timerx-app/deploys/61e192890f6250000848ab6e |
Any toggle for that though? |
Wait I'll try activating checks for macOS and Linux. |
Can you try opening a Gitpod env and test it? Also try testing the same on your Mac Mini. But don't use your dad's Mac Mini. git clone https://github.com/sumeshir26/TimerX.git
cd TimerX
git checkout Blur
git fetch && git pull
pip install -r requirements.txt
python main.py Check the TimerX console on Gitpod for the error. I will test on my RasPi soon, kinda busy. |
@not-nef This is definitely not intended LOL 😂:- |
lol that's abnormal |
Well no it isnt lmao |
Uhm, why? |
To make sure that blur isnt broken on Mac |
I was planning to disable it for mac, but ok |
And the dmg still doesn't work i thought you guys dropped macos support |
That was just the DMG build. The real test has to be done on a real/imaginary(VM) computer. |
But it doesn't run the dmg so i thought you dropped macos support @im-coder-lg |
@sumeshir26 can you give me instructions on what to do next in this pr? |
@not-nef First, I'll create a PR in the Sun Valley TTk Theme Repo to make the Button and AccentButton background transparent. |
@sumeshir26 Is there a way to make the corners of the buttons transparent? I think it has to do something with the custom theme because the ttk.Button has no |
And btw the labels are fixed i just took the old screenshot |
@im-coder-lg Can you manually run the checks on this one pls? It still annoys me |
Just update your branch and make another change, the checks autoupdate. |
This comment has been minimized.
This comment has been minimized.
Can you check if the file has exactly 702 lines? |
Did the theme atleast load? |
Nope. |
Yeah it does. |
@im-coder-lg Run |
That is what I ran, |
No, run it again. GH CLI creates a local branch if the PR is from another fork, so |
Nothing changed. Is there a module error? |
Before you ask, the branch is fully updated and I haven't added any new changes. |
It's all with the theming! I changed the theme and the old UI is back! So, you might've done something(accidentally) to theming! |
For me, it works absolutely beautifully. It is nice and acrilic. can you try to replace all instances of |
Also, look here: |
Ok |
Fixed |
|
Or it was just CMD. |
Nothing seems to work yet again. |
It seems to have fixed itself. It's puzzling to myself. |
Ok, So approve this PR |
One minute, apologies. I want to test this again, final test run. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, everything's good. The toast notif fails but we'll fix that later.
Lets go |
@not-nef can you restore this branch? |
I'm thinking of reverting this merge, making another PR from this branch and fixing this, |
No, he fixed it in #65 |
Im Back.