Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serde support #179

Closed
zesterer opened this issue Jul 16, 2019 · 6 comments
Closed

Add serde support #179

zesterer opened this issue Jul 16, 2019 · 6 comments

Comments

@zesterer
Copy link

It would be very useful to be able to serialise things like the colour and attribute types in crossterm.

@TimonPost
Copy link
Member

Good idea, however, it needs to be behind a feature flag.

@arnej
Copy link
Contributor

arnej commented Jul 31, 2019

This would be very useful for me. I need KeyEvent to implement Deserialize and Serialize.
Can you tell us why this needs to be behind a feature flag?

I would like to help with this if I can.

@TimonPost
Copy link
Member

I have two reasons for that:

  1. Because I want to have as less external deps as possible. Currently, I only have WinApi and Libc.
  2. Not all users are going to use serde serialize and deserialize and the dependencie to serde is going to be unnecessarily in most cases.

If you have questions on how to implement this please ask away here :)

@arnej
Copy link
Contributor

arnej commented Jul 31, 2019

That sounds reasonable :)

I will have a look at this soon and will come back to you when I can't find out how to implement this as a feature.

@arnej
Copy link
Contributor

arnej commented Aug 6, 2019

I finally had the time to work on this. See my pull request here: #190

@TimonPost
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants