Implement Java 8 Constants #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TkTech
reviewed
Apr 12, 2017
jawa/constants.py
Outdated
| @@ -506,7 +575,26 @@ def pack(self, fout): | |||
| constant._name_index, | |||
| constant._descriptor_index | |||
| )) | |||
|
|
|||
| elif isinstance(constant, ConstantMethodHandle): | |||
| write(pack( | |||
There was a problem hiding this comment.
Github messing up here or is this indentation way off?
There was a problem hiding this comment.
It looks fine in raw on GitHub, I've noticed there was a blank line missing after the else if block so I've added that on. Let me know if anything else is missing.
|
This is what I'm seeing:
Just gotta fix the indentation and this can go in, thanks! |
|
@TkTech Formatting should be fixed now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per https://docs.oracle.com/javase/specs/jvms/se8/html/jvms-4.html
Untested for writing but tested for reading.
(No automated tests at the moment)