Trivial port to Py3, hello_world works. Still compatible with Py2 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hon2 This commit is 90% ImportExceptions and one trivial change to encoding strings. Hope to maintain Py2/Py3 compatibility moving forward. Might break other things, only tested hello_world
Necessary to make disassemble example work in both Python2 and Python3
Decode special case string read to utf-8 Check for unicode in UTF-8 constant so it can accept bytes and unicode strings
Some "UTF-8 strings" aren't actually valid UTF-8 strings. See avo.class in the Minecraft 1.8.3 jar for an example of this. This patch just gracefully skips those broken strings and leaves them as bytes.
|
Irrelevant now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is 90% ImportExceptions and one trivial change to encoding strings.
Hope to maintain Py2/Py3 compatibility moving forward
Might break other things, only tested hello_world