Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resend macros draft #360

Closed
wants to merge 8 commits into from

Conversation

VictorDenisov
Copy link
Contributor

@dl1jbe @zcsahok I'm working on a fix for #332.
The work is in progress, but I thought maybe you could take an early look and say if you approve the overall direction.
Basically I want to make sendbuf accept qso_values_t type. It's going to use those values to expand macros in the buffer.
Depending on the situation we will be passing current_qso_values or last_qso_values into the sendbuf function.
If callsign field is empty we will be passing last_qso_values otherwise we will be passing current_qso_values.

What do you think?

@zcsahok
Copy link
Member

zcsahok commented Nov 7, 2022

We could maybe drop qsonrstr altogether and use qso_nr of qso_t. qsonrstr seems to be a leftover from the times when even a sprintf was considered a performance hog. This would also save us tracking both values in parallel.

Then macro expansion could either use values from current_qso or from previous_qso pointing to the last QSO in qso_array, as you suggested.

@VictorDenisov VictorDenisov mentioned this pull request Nov 8, 2022
@VictorDenisov
Copy link
Contributor Author

Closing this PR in favor of #361

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants