-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resend macros #361
Resend macros #361
Conversation
Re-sent serial looks OK now. |
I think I addressed all comments. |
Thanks, will make a final test tomorrow. Two minor points:
|
Just for the record, there are two minor issues related to the re-send functionality in general.
Both globals have to be dropped and this will require a separate PR. |
a544ed4
to
de246b5
Compare
I didn't quite understand the comment about confirm call. But I fixed rst field. |
Thanks for the RST fix! Please also remove the global variable S&P works now OK. For confirming call I meant the message sent on pressing |
Thanks! Merged in master to resolve the merge conflict. |
This is another approach to solving this problem: #332.
Compared to #360 this PR minimally touches existing code.
It's easier to prove that this code doesn't break any existing behavior.
We can make new behavior configurable if you are not certain whether it can suit everyone.