Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blacken repo #218

Merged
merged 2 commits into from Feb 15, 2022
Merged

Blacken repo #218

merged 2 commits into from Feb 15, 2022

Conversation

adamjstewart
Copy link
Collaborator

This PR uses black and isort to auto-format the repo. These tools are developed by PSF and PyCQA and used by many projects to enforce a common PEP-8 compliant standard. Unlike flake8, these tools are auto-formatters, so if someone submits a PR that doesn't pass these tests, they simply need to run black . or isort . in the repo and it will solve all of their issues. This was incredibly useful when working on #215 since the type hints I added increased the line length of most function signatures above the 88 character limit. Downside is that git blame is much less useful now since this PR affects most files. But the same will be true with #215 since it edits every function signature.

@hobu hobu added this to the 1.0.0 milestone Feb 15, 2022
@hobu hobu merged commit 7a6eae1 into Toblerity:master Feb 15, 2022
@adamjstewart adamjstewart deleted the black-isort branch February 15, 2022 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants