Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Travis fail on addr_resolve testing #630

Merged
merged 3 commits into from
Dec 14, 2017
Merged

Fix for Travis fail on addr_resolve testing #630

merged 3 commits into from
Dec 14, 2017

Conversation

Diadlo
Copy link

@Diadlo Diadlo commented Dec 9, 2017 •
edited by iphydf
Loading

This change is Reviewable

@robinlinden
Copy link
Member

:lgtm_strong:

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks broke.

Comments from Reviewable

@sudden6
Copy link

sudden6 commented Dec 10, 2017

:lgtm_strong:

Reviewed 1 of 1 files at r1, 2 of 2 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending.

Comments from Reviewable

@SkyzohKey SkyzohKey added CAT:coverage P2 Medium priority labels Dec 12, 2017
@nurupo nurupo mentioned this pull request Dec 13, 2017
Merged
@robinlinden robinlinden merged commit 998f584 into TokTok:master Dec 14, 2017
@robinlinden robinlinden added this to the v0.1.11 milestone Dec 14, 2017
@robinlinden
Copy link
Member

Merged in #635 as Travis required several of the open PRs to pass and I'm unable to merge anything without Travis passing.

@iphydf iphydf added the test Adding missing tests, refactoring tests; no production code change label May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
P2 Medium priority test Adding missing tests, refactoring tests; no production code change
Projects
None yet
Milestone
v0.1.11
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Diadlo @robinlinden @sudden6 @SkyzohKey @iphydf