Include only needed crossbeam dependencies #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
repi
force-pushed
the
reduce-crossbeam
branch
from
aa90558
to
829de34
Compare
26 tasks
When building without `par-schedule` feature one only needs the crossbeam-channel crate, not all the other parts of crossbeam. This reduces compile times when building with few features. And when building with that feature, we only additionally need crossbeam-queue. Although in practice in that case one gets rest of crossbeam due to rayon.
repi
force-pushed
the
reduce-crossbeam
branch
from
829de34
to
76cd716
Compare
|
I have a change removing crossbeam from non-par-schedule entirely, so it may supercede this PR. SeqQueue usage causes ordering issues for CommandBuffer, so it's being removed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building without
par-schedulefeature one only needs the crossbeam-channel crate, not all the other parts of crossbeam.This reduces compile times when building with few features. We ran into this because we are building with
default-features = falseand wanted to reduce amount of dependencies and improve build times.And when building with that feature, we only additionally need crossbeam-queue. Although in practice in that case one gets rest of crossbeam due to rayon.