extracted ClassTypeDetector to ease re-use
#64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Jun 26, 2023
| $classReflection = $scope->getClassReflection(); | ||
| if ($classReflection instanceof ClassReflection && $classReflection->isSubclassOf( | ||
| 'PHPUnit\Framework\TestCase' |
There was a problem hiding this comment.
before this PR, this check was missing PHPUnit_Framework_TestCase
staabm
commented
Jun 26, 2023
| @@ -14,17 +14,24 @@ final class PublicClassMethodMatcher | |||
| * @var string[] | |||
| */ | |||
| private const SKIPPED_TYPES = [ | |||
| 'PHPUnit\Framework\TestCase', | |||
There was a problem hiding this comment.
before this PR, this check was missing PHPUnit_Framework_TestCase
staabm
commented
Jun 26, 2023
|
|
||
| final class ClassTypeDetector | ||
| { | ||
| public function isTestClass(ClassReflection $classReflection): bool |
There was a problem hiding this comment.
after this PR, it will also be easier to integrate other test-frameworks, which use different base-classes.
just a matter of adjusting a single method in the repo as of now.
|
Thank you, I like this improvement 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preparation for #49
also fixes compat with older phpunit versions when
PHPUnit_Framework_TestCaseis used