#56 #121 #124: Initializes boto3 session globally to support configured AWS profile when calling boto3 #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 29, 2022 22:51
…upport configured AWS profile when calling boto3
nicor88
pushed a commit
to Avinash-1394/dbt-athena
that referenced
this pull request
Jan 27, 2023
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is yet another duplicate of #56 #121 #124. Due to the fact that #56 has been lying around for quite some time (outdated version of the code), #124 addresses the issue in only one instance of the adapter i.e.
clean_up_table, I decided to go with the approach introduced in #121 by @cstruct and included a global variable that holds theboto3_sessionthat can be retrieve at any point in time viaget_boto3_session(). I would be happy to decline this PR in favour of #121 if preferred as it addresses the the issue at hand.Thank you in advance.