Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect configured AWS profile when calling boto3 #121

Closed
wants to merge 1 commit into from
Closed

Respect configured AWS profile when calling boto3 #121

wants to merge 1 commit into from

Conversation

cstruct
Copy link

@cstruct cstruct commented Aug 17, 2022

Use a shared boto3.session.Session between pyathena and manual
boto3 calls. This fixes #120

Use a shared `boto3.session.Session` between `pyathena` and manual
`boto3` calls. This fixes #120
@owenprough-sift
Copy link

How similar is this PR to #56 ?

@cstruct
Copy link
Author

cstruct commented Aug 17, 2022

Aah, I obviously don't know how to search. This PR is very similar, where it differs is that it shares one session with pyathena and that the bug is fixed for newly introduced usages of boto3. I can close this in favor of the old one if that is preferable and it is updated to cover the new places that boto3 is used.

@w0rks74710n
Copy link

#125 leverages this approach and introduces a global variable that holds the boto3_session that can be retrieve at any point in time via get_boto3_session(). Happy to decline that PR in favour of this one. As I mention #125, #56 has been lying around for quite some time (outdated version of the code) and #124 addresses the issue in only one instance of the adapter i.e. clean_up_table.

@cstruct cstruct closed this Nov 29, 2022
@cstruct cstruct deleted the fix-boto3-aws-profile branch November 29, 2022 08:20
nicor88 pushed a commit to Avinash-1394/dbt-athena that referenced this pull request Jan 27, 2023
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS profile not respected by boto3 calls
3 participants