Support AWS profile when accessing Glue, S3 #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chronitis
changed the title
|
Rebased on 1.0.1 |
chronitis
force-pushed
the
nvlt/fix-aws-profile
branch
from
52ec0c1
to
a9acaf0
Compare
|
hey @chronitis only saw this now, I think we are solving the same issue but on two different places in slightly different ways: #124, we should probably stick to the same solution and use on both places (probably on others that call a new client as well) |
w0rks74710n
pushed a commit
to w0rks74710n/dbt-athena
that referenced
this pull request
Aug 29, 2022
…upport configured AWS profile when calling boto3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a (minimal) fix for #55 - direct construction of
boto3.{Client,Resource}is replaced by constructing aboto3.session.Session(passing bothregion_nameandaws_profile_namefrom the credentials, so they'll be used if non-null) and then using that to access resources.