Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write unit tests for parallel prediction and parallel refitting #33

Closed
TommyJones opened this issue Jul 7, 2020 · 2 comments
Closed

Write unit tests for parallel prediction and parallel refitting #33

TommyJones opened this issue Jul 7, 2020 · 2 comments
Labels
CRAN Needed before release (or update) to CRAN

Comments

@TommyJones
Copy link
Owner

No description provided.

@TommyJones TommyJones added the CRAN Needed before release (or update) to CRAN label Jul 7, 2020
@TommyJones
Copy link
Owner Author

While you're at it, build in checks so that you don't have more threads than documents for predict.

Sanity check number of documents per thread too. If average is too low, then issue a warning/message and correction. Check Mallet docs to see if they have a rule of thumb.

@TommyJones
Copy link
Owner Author

le fin 35ce77f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CRAN Needed before release (or update) to CRAN
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TommyJones