Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS review: Comments on the paper #76

Closed
maximelenormand opened this issue Jul 3, 2024 · 3 comments
Closed

JOSS review: Comments on the paper #76

maximelenormand opened this issue Jul 3, 2024 · 3 comments

Comments

@maximelenormand
Copy link

I have two general comments on the paper.

  • The summary should focus on your package and not on the tidy universe. Please use this section to describe the functionality and purpose of your package for a diverse, non-specialist audience.

  • The state of need/field section could be developed by listing the main packages that implement topic models in R (and other languages) and explaining in detail why your software is much better than the other options.

#6800

@TommyJones
Copy link
Owner

I believe I addressed these issues with this commit 6e8e2f5

Can you confirm that's sufficient (or not)? I'll leave this issue open until then.

@maximelenormand
Copy link
Author

That's fine by me. Thanks.

@TommyJones
Copy link
Owner

Awesome. Thank you so much for your time and effort in reviewing and making both the paper and the tidylda package better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants