Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect objective calculation for SIRT #1787

Open
MargaretDuff opened this issue Apr 23, 2024 · 1 comment · May be fixed by #1790
Open

Incorrect objective calculation for SIRT #1787

MargaretDuff opened this issue Apr 23, 2024 · 1 comment · May be fixed by #1790
Assignees
Labels
bug Something isn't working

Comments

@MargaretDuff
Copy link
Member

Description

In SIRT the objective calculation is here:

def update_objective(self):
r"""Returns the objective
.. math:: \frac{1}{2}\|A x - b\|^{2}
"""
self.loss.append(0.5*self.r.squared_norm())

But $r\neq Ax-b$ because it is modified by the preconditioner:

Instead, we should have

    def update_objective(self):
        r"""Returns the objective

        .. math:: \frac{1}{2}\|A x - b\|^{2}

        """
        self.loss.append(0.5*(self.operator.direct(self.x)-self.data).squared_norm())
@MargaretDuff MargaretDuff added the bug Something isn't working label Apr 23, 2024
@MargaretDuff
Copy link
Member Author

@epapoutsellis - if you have a moment, please can you sense check this for me?

@MargaretDuff MargaretDuff self-assigned this Apr 23, 2024
@MargaretDuff MargaretDuff linked a pull request Apr 23, 2024 that will close this issue
9 tasks
@gfardell gfardell added this to the v24.2.0 milestone Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Blocked
Status: PRs to review
Development

Successfully merging a pull request may close this issue.

3 participants