We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In SIRT the objective calculation is here:
CIL/Wrappers/Python/cil/optimisation/algorithms/SIRT.py
Lines 203 to 209 in 9ba92fe
But $r\neq Ax-b$ because it is modified by the preconditioner:
Line 193 in 9ba92fe
Instead, we should have
def update_objective(self): r"""Returns the objective .. math:: \frac{1}{2}\|A x - b\|^{2} """ self.loss.append(0.5*(self.operator.direct(self.x)-self.data).squared_norm())
The text was updated successfully, but these errors were encountered:
@epapoutsellis - if you have a moment, please can you sense check this for me?
Sorry, something went wrong.
MargaretDuff
Successfully merging a pull request may close this issue.
Description
In SIRT the objective calculation is here:
CIL/Wrappers/Python/cil/optimisation/algorithms/SIRT.py
Lines 203 to 209 in 9ba92fe
But$r\neq Ax-b$ because it is modified by the preconditioner:
CIL/Wrappers/Python/cil/optimisation/algorithms/SIRT.py
Line 193 in 9ba92fe
Instead, we should have
The text was updated successfully, but these errors were encountered: