Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: support for tempo modulation #40

Closed
YuiyuD001 opened this issue Aug 7, 2017 · 3 comments
Closed

Feature request: support for tempo modulation #40

YuiyuD001 opened this issue Aug 7, 2017 · 3 comments

Comments

@YuiyuD001
Copy link

I love your tool, but like a title, when I converting midi have multi tempo, the times not coincide anymore, can you improve it! Thank you so much for this!
image
@YuiyuD001 YuiyuD001 changed the title Time when converted don't coincide with midi have muti tempo Time when converted don't coincide with midi have multi tempo Aug 7, 2017
@tambien
Copy link
Contributor

tambien commented Sep 23, 2017 •
edited
Loading

Currently only one tempo is supported. I am trying to keep this as minimal and compatible with Tone.js as possible and haven't figured out an elegant API to handle tempo modulations. If you have any proposals, i would happily review

@appsforartists appsforartists changed the title Time when converted don't coincide with midi have multi tempo Feature request: support for tempo modulation Dec 27, 2017
@LenweSaralonde
Copy link

I need this for my project so I implemented it : #55
The tests needs to be adjusted since one of the MIDI files has tempo variation.

@Topograph Topograph mentioned this issue Nov 25, 2018
Closed
@tambien
Copy link
Contributor

tambien commented Feb 15, 2019

duplicate of #63

@tambien tambien closed this as completed Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tambien @YuiyuD001 @LenweSaralonde