Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show password checkbox gets enabled on clicking outside the label #3267

Closed
withshubh opened this issue Jun 13, 2022 · 9 comments
Closed

show password checkbox gets enabled on clicking outside the label #3267

withshubh opened this issue Jun 13, 2022 · 9 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers up-for-grabs

Comments

@withshubh
Copy link
Contributor

What is the expected behaviour?

On the login screen show password checkbox should not be enabled when clicked outside the label.

What is the current behaviour?

The show password gets enabled when clicked outside the label

How to reproduce the issue?

  1. Go to the login screen of ToolJet
  2. Click anywhere on the right side of the show password

Screenshots or Screencast

show-password

@withshubh withshubh added bug Something isn't working good first issue Good for newcomers up-for-grabs labels Jun 13, 2022
@Owillz01
Copy link
Contributor

hello, kindly assign me to fix this.

@withshubh
Copy link
Contributor Author

Hey, @Owillz01 Glad to know that you're interested but there's already one issue assigned to you, please submit a PR for that first.

@Owillz01
Copy link
Contributor

Hi @withshubh I have submitted a PR for that already. did that few minutes before making this post

@withshubh
Copy link
Contributor Author

withshubh commented Jun 15, 2022

@Owillz01 Great! Assigned this issue to you.

@withshubh
Copy link
Contributor Author

Hey @Owillz01 👋
Friendly bump - Are you working on this issue?

@Owillz01
Copy link
Contributor

hi @withshubh
yes i am.

@Syed-Ansar
Copy link
Contributor

I have resolved issue. I will make a PR if @withshubh agree. can watch here

@withshubh
Copy link
Contributor Author

withshubh commented Jun 21, 2022

Hey @Syed-Ansar 👋
Glad that you were able to find a solution to this issue but it is currently assigned to @Owillz01 .
You can create a PR for this but we can't assure to merge your PR as we assign issues on a first come first served basis.

@Syed-Ansar
Copy link
Contributor

Oh that's okay. Let's see if @Owillz01 make a PR then I won't if he doesn't then I would be happy to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers up-for-grabs
Projects
None yet
4 participants