Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More Event information to DiscordHook #400

Closed
NeotenySS opened this issue Oct 31, 2021 · 0 comments · Fixed by #401
Closed

More Event information to DiscordHook #400

NeotenySS opened this issue Oct 31, 2021 · 0 comments · Fixed by #401
Assignees
@LlmDl
Labels
enhancement New feature or request
Milestone
0.6.4

Comments

@NeotenySS
Copy link

Need add more information to SiegeEndEvent.java
(Now we have only: public String getBesiegedTownName() Town name besieged).

  1. Need add win/defeat city.
  2. Can translate text (because text write only English, but need other languages too, example SiegeType (in PreSiegeWarStartEvent) output only English language, but need other translate too).
  3. Need add who captured city or who try capture, but lose.

Look Example to PreSiegeWarStartEvent.java

  1. private final SiegeType siegeType; (can output type siege to discord).
  2. private final Town townOfSiegeStarter; (who start siege (Town) output to discord).
  3. private final Town targetTown; (Target town (Name) output to discord).

P.S.: It will be cool if you can add a function to translate text (events that are called from the code) as it was connected with the SiegeType example.

And I'm sorry for my bad english
@NeotenySS NeotenySS added the enhancement New feature or request label Oct 31, 2021
LlmDl added a commit that referenced this issue Oct 31, 2021
@LlmDl
Enhance Start and End Siege Events
9948084 
This PR adds more methods to the events thrown at start and end of
sieges.

It also adds a SiegeSide variable to Sieges: SiegeWinner.

Closes #400.
LlmDl added a commit that referenced this issue Oct 31, 2021
@LlmDl
Enhance Start and End Siege Events
025fde8 
This PR adds more methods to the events thrown at start and end of
sieges.

It also adds a SiegeSide variable to Sieges: SiegeWinner.

Closes #400.
Whitespacing fixes.
@LlmDl LlmDl mentioned this issue Oct 31, 2021
Merged
1 task
@LlmDl LlmDl added this to the 0.6.4 milestone Oct 31, 2021
@LlmDl LlmDl self-assigned this Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LlmDl LlmDl

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.6.4
Development

Successfully merging a pull request may close this issue.

Enhance Start and End Siege Events TownyAdvanced/SiegeWar
2 participants
@LlmDl @NeotenySS